You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where the depot message was sent even when no depot was nearby.
Also improves readability and prevents potential errors when accessing nil tiles.
Video.sem.titulo.Feito.com.o.Clipchamp.mp4
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
You can improve the function in the special tiles file without migrating to the libs.
It is a function of the player class, all class functions are in their respective files, unless it is a local function, then it would make sense.
It's not necessary to move all player functions to the lib.
If you follow this logic, you would have to move, for example, the player functions of hirelings and of gamestore, which doesn't make sense, as they are local functions used by the systems.
In this case, it is a local function used for the special tiles.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omarcopires
force-pushed
the
fix-special-tile
branch
from
Description
Fixes an issue where the depot message was sent even when no depot was nearby.
Also improves readability and prevents potential errors when accessing nil tiles.
Video.sem.titulo.Feito.com.o.Clipchamp.mp4
Type of change
Checklist